javascript - How can I refactor this jQuery code? -


The code below is for a simple newsletter signup widget.

I'm sure there is a way to make it more concise, any thoughts? 

  var email_form = $ ('. Widget_subscribe form'); Var email_submit = $ ('. Widget_subscribe. Submit'); Var email_link = $ ('. Widget_subscribe .email'); // When the page loads email_form.hide (); Hide the email entry form; // Show the form when clicking email link $ (email_link) Click (function () {$ (this) .toggle (); $ (email_form) .toggle (); return returned;}); // Hide the form form, when the form is submitted $ (email_submit) Click (function () {$ (email_link) toggle (); $ (email_form) .toggle ();}); // clear / reset email input on Focus $ ('Input [name = "email"]'. Focus (function () {$ (this) .val ("");}) Blur (function () { If ($ (this) .val () == "") {$ (this) .val ($ (this) [0] .defaultValue)}}});

You have some similar code. 

  / Click the $ / email link to show $ (email_link) click (function () {$ (this) .toggle (); $ (email_form) .toggle (); description is false;}) // form Hide the form, when submitted the form $ (Email_submit) Click (function () {$ (email_link) toggle (); $ (email_form) .toggle ();});

This re-apply Can be done so that the equality becomes clear.

// click ( Function () {$ (email_link) Toggle (); $ (email_form). Toggle (); Return Back;}); // Hide the form form, when the form is submitted $ (email_submit) Click (function () {$ (email_link) toggle (); $ (email_form) .toggle ();});

So you can toggle the link and the form in the panel. 

  var toggleEmailLinkAndForm = function) {$ (Email_link). Toggle (); $ (Email_form) .toggle (); } $ (Email_link). Click (toggleEmailLinkAndForm); $ (Email_submit) .click (toggleEmailLinkAndForm);

And as the others have said, you can drop the redundant $ () s. 

  var toggle email mail and form = function () {email_link.toggle (); Email_form.toggle (); } Email_link.click (toggleEmailLinkAndForm); Email_submit.click (toggleEmailLinkAndForm);

Comments

Post a Comment

Popular posts from this blog

python - Overriding the save method in Django ModelForm -

I'm having trouble overriding a ModelForm save method. I get this error I'm: Exception type: TypeErier Exception Value: Save () found an unexpected keyword argument 'committed' My intentions include a form 3 fields Submit several values ​​for, then create an object for each combination of those areas, and to save each object file models.py class collarsult type (models.Model): id = model. AutoField (db_column = 'icontact_result_code_type_id', primary_key = true) callResult = models.ForeignKey ( 'CallResult', db_column = 'icontact_result_code_id') campaign = models.ForeignKey ( 'campaign', db_column = 'icampaign_id') CALLTYPE = models.ForeignKey ( 'CALLTYPE', db_column = 'icall_type_id') agent = models.BooleanField (db_column = 'bagent', default = true) teamLeader = models.BooleanField (db_column = 'bTeamLeader', default = true) active = models.BooleanField (db_column = Django.form...
Read more

html - CSS autoheight, but fit content to height of div -

I have a div in which there are three children- div in the left and middle div: float: left while true: float: true because it is my layout Actually will spoil, I've used ClearFix Hack: .cf {zoom: 1; }. Cf: First,. Cf: {content: ""; Display: Table; }. Cf: After {clear: both; } It still works, but I want to be the right div an indicator. So it should fill 100% of the parent unit of height. How can I complete this? PS is the full code: & Lt; / Div & gt; & Lt; Div class = "mobile_content" & gt; & Lt; H5 & gt; {{Data.titel}} & lt; / H5> & Lt; Table & gt; & Lt; TR & gt; & Lt; Th & gt; Komponist: & lt; / Th & gt; & Lt; TD & gt; {{Data.komponist}} & lt; / TD & gt; & Lt; / TR & gt; & Lt; TR & gt; & Lt; Th & gt; Instrument: & lt; / Th & gt; & Lt; TD & gt; {{Data.instrumente}} & lt; / TD & gt; & Lt; / TR & gt;...
Read more

qt - How to prevent QAudioInput from automatically boosting the master volume to 100%? -

I have been trying to use Qt5 multimedia to record audio with QAudioInput, however, when I see If QAudioInput is started, it increases the master volume of my sound device to 100%. How can I prevent QAudioInput from changing the master volume? My current development platform is Linux with PalsAdio (with flat audio disabled). How can I use QAudioInput : QAudioDeviceInfo device_info = QAudioDeviceInfo :: defaultInputDevice (); QAudio format format; Format.setSampleRate (44100); Format.setChannelCount (1); Format.setSampleSize (16); Format.setCodec ("Audio / PCM"); Format.setSampleType (QAudioFormat :: SignedInt); Format.setByteOrder (QAudioFormat :: LittleEndian); Std :: cout & lt; & Lt; Device_info.deviceName (). ToUtf8 (). ConstData () & lt; & Lt; Std :: endl; QAudioInput * default_device = new QAudioInput (device_info, format); QIODevice * default_io_device = default_device-> Start (); a QAudioInput.setVolume () method is not you I ...
Read more